-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the codebase #8
Comments
What do we have to do here exactly? 🤔 As I understood the commitcomment right we have two options for releasing a new npm-package: -> Otherwise we can publish breaking changes. Or am I wrong? What do you mean with |
The Swift binary is an implementation detail and not exposed to users, so none of your proposed TODOS are necessary. The idea of passing JSON to the binary is to simplify the communication. Right now it's just using a bunch of arguments. We could switch to use proper CLI flags, but since it's not exposed anyways, it would be simpler to just send all the options from Node.js as JSON and parse the JSON into an options dictionary on the Swift side. That way we don't have to do much on the communication side when adding new options. |
@LarsJK Do you know any better way we could use to communicate between Swift and Node.js? We'll eventually want two-way communication, so the current method is not going to be very optimal. Maybe something like https://www.npmjs.com/package/node-ipc ? |
Sorry I don't really have any experience with this. Dont know if this can be useful: https://realm.io/news/thomas-goyne-fast-inter-process-communication/ |
From ac3dcc4#commitcomment-20097149:
The text was updated successfully, but these errors were encountered: