Add movieFragmentInterval option
#67
Conversation
| @@ -60,7 +61,7 @@ public final class Aperture: NSObject { | |||
|
|
|||
| // Needed because otherwise there is no audio on videos longer than 10 seconds | |||
| // http://stackoverflow.com/a/26769529/64949 | |||
| output.movieFragmentInterval = .invalid | |||
| output.movieFragmentInterval = movieFragmentInterval != nil ? CMTimeMake(value: movieFragmentInterval!, timescale: 1) : .invalid | |||
There was a problem hiding this comment.
CMTimeMake is legacy. Use the more modern initializer.
sindresorhus
changed the title
movieFragmentInterval option
How are you using a |
| @@ -40,6 +40,7 @@ public final class Aperture: NSObject { | |||
| highlightClicks: Bool, | |||
| screenId: CGDirectDisplayID = .main, | |||
| audioDevice: AVCaptureDevice? = .default(for: .audio), | |||
| movieFragmentInterval: Int64? = nil, | |||
There was a problem hiding this comment.
Can you add a doc comment about what this does and what it's useful for?
|
Checking in @drag0s, would you still like to continue on this implementation? |
|
Hey there, sorry for my delayed response.
I use a The main problem about not using In the case of using
Yes, as long as you guys think it's worth adding it! |
|
I didn't realize the API automatically chose the correct container based on the output URL extension. Do we even need an option at all? Can't we just use |
Add option to customize movieFragmentInterval. The default will be the same as before (
.invalid)Probably it didn't worked before because you were trying with
mp4containers, but it does work withmovcontainers and it's nice to be able to change this option.