Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaleFactor parameter #73

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Conversation

alexpelan
Copy link
Contributor

This lets consumers specify the scaleFactor to use when talking to
AVCaptureScreenInput. This was useful to me for keeping file sizes
down, particularly on my Macbook Pro's retina display.

This lets consumers specify the scaleFactor to use when talking to
`AVCaptureScreenInput`. This was useful to me for keeping file sizes
down, particularly on my Macbook Pro's retina display.
@sindresorhus sindresorhus changed the title Add scaleFactor to parameters to control file size Add scaleFactor parameter Feb 25, 2021
Copy link
Contributor

@sindresorhus sindresorhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Seems like I had reviewed this a long time ago, but forgot to click the "request changes" button to finalize the review...

Sources/Aperture/Aperture.swift Outdated Show resolved Hide resolved
Sources/Aperture/Aperture.swift Outdated Show resolved Hide resolved
@alexpelan alexpelan requested a review from sindresorhus March 24, 2021 15:29
@sindresorhus sindresorhus merged commit 8a326d3 into wulkano:main Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants