Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #529: Fix typo in the error message #530

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Fix #529: Fix typo in the error message #530

merged 1 commit into from
Sep 7, 2023

Conversation

petrdvorak
Copy link
Member

Optimize imports

romanstrobl
romanstrobl approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

banterCZ
banterCZ approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice catch but but pity about the organizing imports in the not affected classes. It was not needed and in general, it complicates backporting and cherry-picking.

@petrdvorak petrdvorak merged commit 504c9a4 into develop Sep 7, 2023
4 checks passed
@petrdvorak petrdvorak deleted the issues/529-typo branch September 7, 2023 10:00
banterCZ pushed a commit that referenced this pull request Sep 7, 2023
@petrdvorak @banterCZ
Fix #529: Fix typo in the error message (#530)
82d24e0 
Optimize imports

(cherry picked from commit 504c9a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

@hvge hvge hvge approved these changes

@romanstrobl romanstrobl romanstrobl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petrdvorak @banterCZ @hvge @romanstrobl