Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1656: Enable parameterisation of TOTP #1676

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

jnpsk
Copy link
Collaborator

@jnpsk jnpsk commented Sep 13, 2024

No description provided.

romanstrobl
romanstrobl previously approved these changes Sep 16, 2024
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest correcting the semantics of `proximityCheckStepLength. '

Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@jnpsk jnpsk merged commit 96208b7 into develop Sep 19, 2024
2 checks passed
@jnpsk jnpsk deleted the issues/1656-totp-parameters branch September 19, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants