Fix #1684: Update Client and Admin Console #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanstrobl
requested changes
Oct 1, 2024
...auth-admin/src/main/java/io/getlime/security/app/admin/controller/ApplicationController.java
Outdated
Show resolved
Hide resolved
banterCZ
reviewed
Oct 1, 2024
| final UpdateCallbackUrlRequest request = new UpdateCallbackUrlRequest(); | ||
| request.setId(id); | ||
| request.setApplicationId(applicationId); | ||
| request.setName(name); | ||
| request.setType(type.toString()); |
There was a problem hiding this comment.
🤔 Why is type a type of String instead of Enum? I know, we should solve this in a separate PR if agreed.
There was a problem hiding this comment.
I was thinking about that too, but I didn't want to include this type of change in this PR.
banterCZ
approved these changes
Oct 2, 2024
| @@ -157,7 +160,7 @@ public String applicationVersionCreate(@PathVariable("applicationId") String id, | |||
| * @param model Model with passed parameters. | |||
| * @return "callbackCreate" view. | |||
| */ | |||
| @GetMapping("/application/detail/{applicationId}/callback/create") | |||
| @GetMapping("/application/detail/{applicationId}/callback/create/form") | |||
There was a problem hiding this comment.
Changing URL is not backward compatible but for Admin API we may afford that.
There was a problem hiding this comment.
Yes, I think we can assume those are just called internally.
| * @return Information about new callback URL object. | ||
| * @throws PowerAuthClientException In case REST API call fails. | ||
| */ | ||
| CreateCallbackUrlResponse createCallbackUrl(String applicationId, String name, CallbackUrlType type, String callbackUrl, List<String> attributes, HttpAuthenticationPrivate authentication) throws PowerAuthClientException; | ||
| CreateCallbackUrlResponse createCallbackUrl(String applicationId, String name, CallbackUrlType type, String callbackUrl, List<String> attributes, HttpAuthenticationPrivate authentication, Duration retentionPeriod, Duration initialBackoff, Integer maxAttempts) throws PowerAuthClientException; |
There was a problem hiding this comment.
Carthago delenda est
In long term, I prefer using methods with request object only and mark these as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PA Admin Console and PA Client to reflect changes in Callback Management API (3 new attributes).