Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1702: Use Enum Instead of String for Callback URL Type #1710

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

jnpsk
Copy link
Collaborator

@jnpsk jnpsk commented Oct 3, 2024

No description provided.

romanstrobl
romanstrobl previously approved these changes Oct 3, 2024
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

banterCZ
banterCZ previously approved these changes Oct 3, 2024
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@NotBlank
private String type;
@NotNull
private CallbackUrlType type;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Shouldn't it be reflected in WebServices-Methods.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, added now

@jnpsk jnpsk dismissed stale reviews from banterCZ and romanstrobl via 184b075 October 3, 2024 06:56
@jnpsk jnpsk merged commit 9f7691a into develop Oct 3, 2024
2 checks passed
@jnpsk jnpsk deleted the issues/1702-callback-type-enum branch October 3, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants