Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecations for client methods without all crypto 3.3 parameters #1742

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Add deprecations for client methods without all crypto 3.3 parameters #1742

merged 2 commits into from
Oct 15, 2024

Conversation

romanstrobl
Copy link
Member

No description provided.

@romanstrobl romanstrobl self-assigned this Oct 14, 2024
banterCZ
banterCZ previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! But shouldn't we mention that in the migration guide?

@romanstrobl
Copy link
Member Author

Perfect! But shouldn't we mention that in the migration guide?

Good idea, I will add a note.

banterCZ
banterCZ approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the migration guides.

@romanstrobl romanstrobl merged commit 5bfa4d1 into develop Oct 15, 2024
2 checks passed
@romanstrobl romanstrobl deleted the issues/1741-deprecate-methods-crypto-33 branch October 15, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

Assignees

@romanstrobl romanstrobl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanstrobl @banterCZ