feat(router): remove default high cardinality attributes #1448
+2,985
−1,041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noroth
changed the title
Noroth
force-pushed
the
ludwig/eng-6132-remove-high-cardinal-fields-from-default-attributes
branch
from
c7bfdd2 to
d35b4a9
Compare
StarpTech
changed the title
Noroth
force-pushed
the
ludwig/eng-6132-remove-high-cardinal-fields-from-default-attributes
branch
from
d35b4a9 to
d919d1b
Compare
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
…from-default-attributes
Router image scan passed✅ No security vulnerabilities found in image: |
…from-default-attributes
StarpTech
requested changes
Dec 22, 2024
…from-default-attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Certain metric attributes can cause an excessive amount of metric cardinality. In order to add more flexibility, those attributes should be removed from the default set and be configurable.
These changes are not applied when using the default cloud exporter.
Warning
This is a breaking change as by default certain attributes are now omitted from the default set of attributes.
If metric backends make use of those attributes, they need to be configured or the graphs need to be updated accordingly
Checklist