Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): expose engine statistic metrics #1452

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Noroth
Copy link
Contributor

@Noroth Noroth commented Dec 17, 2024

Motivation and Context

We would like to expose metrics for engine statistics related to subscriptions.

  • number of active connections
  • number of active subscriptions
  • number of active triggers
  • count of sent messages from the engine

Checklist

@Noroth Noroth marked this pull request as ready for review December 18, 2024 09:20
@Noroth Noroth force-pushed the ludwig/eng-5721-add-subscription-count-metric branch from 46768f3 to f72a4ce Compare December 18, 2024 14:48
Copy link

github-actions bot commented Dec 19, 2024

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Dec 20, 2024

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-007ac4062634823b561e4f9d738e558c41e185dd

Copy link
Contributor

@alepane21 alepane21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a test for Ludwig

alepane21
alepane21 previously approved these changes Dec 20, 2024
Copy link
Contributor

@alepane21 alepane21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another test for Ludwig

@alepane21 alepane21 dismissed their stale review December 20, 2024 10:35

it was just a test

Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few nuts but overall great approach and reuse of WebSocket stats.

router/pkg/config/config.schema.json Show resolved Hide resolved
@Noroth Noroth requested a review from StarpTech January 2, 2025 10:18
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants