Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use gauge for server.uptime metric #1510

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

StarpTech
Copy link
Contributor

Motivation and Context

This PR change the server uptime metric from type counter to gauge. Counter was not correct because we are not interested in the aggregation but in the last value.

Checklist

Copy link

github-actions bot commented Jan 12, 2025

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-804bae228417cb3989adef55b3ff695a8086d0be

Copy link
Contributor

@Noroth Noroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit 77a16d2 into main Jan 14, 2025
13 checks passed
@StarpTech StarpTech deleted the dustin/use-gauge-for-server-uptime-metric branch January 14, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants