fix: improve ws subprotocol selection #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… suvij/eng-5142-add-websocket-subprotocol-config-feature
jensneuse
requested changes
May 13, 2024
v2/pkg/engine/datasource/graphql_datasource/graphql_subscription_client.go
Outdated
Show resolved
Hide resolved
v2/pkg/engine/datasource/graphql_datasource/graphql_subscription_client.go
Outdated
Show resolved
Hide resolved
jensneuse
requested changes
May 17, 2024
| } | ||
|
|
||
| // In this case the subgraph doesnt return the subprotocol, so falls back to graphql-ws | ||
| func TestSubprotocolNegotiationWithNoSubprotocol(t *testing.T) { |
There was a problem hiding this comment.
There's a case missing where the protocol is hardcoded through options to "graphql-transport-ws" or did I miss this?
There was a problem hiding this comment.
No, you are right. Done
jensneuse
approved these changes
May 17, 2024
JivusAyrus
deleted the
suvij/eng-5142-add-websocket-subprotocol-config-feature
branch
This was referenced Nov 13, 2024
devsergiy
pushed a commit
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](execution/v1.0.9...execution/v1.1.0) (2024-11-14) ### Features * add data source ID to trace ([#870](#870)) ([beb8720](beb8720)) * add further apollo-compatible error support ([#939](#939)) ([2d08eb6](2d08eb6)) * add query plans ([#871](#871)) ([da79d7e](da79d7e)) * expose acquire resolver wait time in loader hooks ([#854](#854)) ([b85148d](b85148d)) * expose compose method of engine federation config factory ([#878](#878)) ([95e943e](95e943e)) * improve performance and memory usage of loader & resolbable ([#851](#851)) ([27670b7](27670b7)) * improve resolve performance by solving merge abstract nodes in postprocessing ([#826](#826)) ([6566e02](6566e02)) * include subgraph name in ART ([#929](#929)) ([fc0993d](fc0993d)) * rewrite variable renderer to use astjson ([#946](#946)) ([0d2d642](0d2d642)) * subgraph error propagation improvements ([#883](#883)) ([13cb695](13cb695)) * support multiple pubsub providers ([#788](#788)) ([ea8b3d3](ea8b3d3)) * validate returned enum values ([#936](#936)) ([7aa4add](7aa4add)) ### Bug Fixes * argument and variable validation during execution ([#902](#902)) ([895e332](895e332)) * correctly render trace and query plan together ([#874](#874)) ([2fc364f](2fc364f)) * execution validation order, do not reuse planner ([#925](#925)) ([3ffce8b](3ffce8b)) * ignore empty errors ([#890](#890)) ([4c5556f](4c5556f)) * improve ws subprotocol selection ([1fc0dd9](1fc0dd9)) * improve ws subprotocol selection ([#795](#795)) ([ad67dbb](ad67dbb)) * keep scalar order when merging fields in post processing ([#835](#835)) ([d27fb6e](d27fb6e)) * keep unused variables during normalization ([#802](#802)) ([15ae7b3](15ae7b3)) * level of null data propagation ([#810](#810)) ([537f4d6](537f4d6)) * merging fields correctly ([0dfb6a2](0dfb6a2)) * merging fields correctly ([#836](#836)) ([3c4cb17](3c4cb17)) * merging response nodes ([#772](#772)) ([5e89693](5e89693)) * planning of provides, parent entity jump, conditional implicit keys, handling of external fields ([#818](#818)) ([fe6ffd6](fe6ffd6)), closes [#830](#830) [#847](#847) * return empty data when all root fields was skipped ([#910](#910)) ([4607dc0](4607dc0)) * variables normalization for the anonymous operations ([#965](#965)) ([267aef8](267aef8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.