feat: expose compose method of engine federation config factory #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikawaha
changed the title
…ion-result_20240807
devsergiy
reviewed
Aug 21, 2024
|
|
||
| // RouterConfig is an intermediate data that holds the result of the composition | ||
| // and can be saved to a file to configure the router data sources when creating an engine config. | ||
| type RouterConfig struct { |
There was a problem hiding this comment.
Hi @ikawaha
We probably could use proto types directly
Is there any special need for the wrapping structure?
There was a problem hiding this comment.
Thank you for your feedback. I initially wrapped nodev1.RouterConfig because it was hidden, and my goal was to make it serializable. However, I agree that using the proto types directly would be clearer and more straightforward. I've made the necessary adjustments to avoid the wrapping structure and now utilize nodev1.RouterConfig directly.
I've pushed the changes—does this look better to you? 24b4a97
devsergiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, we want to express our respect for the wundergraph team's work on graphql-go-tools. We appreciate the effort that has gone into developing this tool, and we hope that this PR can contribute to improving the performance and memory efficiency of subgraph composition in GraphQL federation.
When building the EngineConfiguration, the BuildEngineConfiguration method performs subgraph composition. This composition is done using the Cosmo library, which generates a serializable data structure known as the router config in the Cosmo library.
As subgraphs grow larger, the time complexity and memory usage of the composition process can become significantly higher. However, if we know when the structure of a subgraph changes, we can reuse the router config to build the EngineConfiguration without recomposing the subgraph.
In this PR, we enable the serialization of the router config (referred to as the intermediate config in graphql-go-tools) used in Cosmo, allowing it to be reused when constructing the EngineConfiguration.
By serializing the router config, we can execute the EngineConfiguration at a lower cost when there are no changes to the subgraph. This is particularly useful during server startup or when refreshing a GraphQL gateway.