Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to collect DS information per operation and ensure corrected errors are passed #899

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

StarpTech
Copy link
Collaborator

No description provided.

Copy link
Contributor

@df-wg df-wg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

How will this be used in the router?

v2/pkg/engine/postprocess/postprocess.go Outdated Show resolved Hide resolved
v2/pkg/engine/postprocess/postprocess_test.go Outdated Show resolved Hide resolved
@StarpTech StarpTech requested a review from df-wg September 27, 2024 09:38
@StarpTech
Copy link
Collaborator Author

How will this be used in the router?

It makes the involved datasource infos available after the post processing step. This info is used to enrich metrics.

@StarpTech StarpTech requested a review from devsergiy September 27, 2024 09:46
@StarpTech StarpTech requested a review from devsergiy September 27, 2024 09:58
@devsergiy devsergiy merged commit 18a5aae into master Sep 27, 2024
8 checks passed
@devsergiy devsergiy deleted the dustin/improve-subgraph-err-handling branch September 27, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants