#99 Fix PHP Stan error with DrupalAutoloader. #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkirsman
commented
May 16, 2024
| @@ -44,7 +44,8 @@ | |||
| "dealerdirect/phpcodesniffer-composer-installer": "*", | |||
| "mglaman/phpstan-drupal": "^1.1", | |||
| "phpstan/extension-installer": "^1.1", | |||
| "phpstan/phpstan-deprecation-rules": "^1.0" | |||
| "phpstan/phpstan-deprecation-rules": "^1.0", | |||
| "webflo/drupal-finder": "^1.3" | |||
There was a problem hiding this comment.
I'm also adding requirement to version as the new class was added in 1.3 webflo/drupal-finder@1.2.2...1.3.0#diff-19dafcffb2094365c57f581c138aede2762e021675c6d8dab34c5dbb78508128R1
hkirsman
commented
May 16, 2024
| @@ -0,0 +1,8 @@ | |||
| services: | |||
There was a problem hiding this comment.
This is not related to current PR. It's something I missed in the GrumpPHP 2.5 update - just a nasty error if psalm task is enabled in grumphp.yml:
tormi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is trivial change atm as we've just disabled Psalm in previous PR #97 We hope to get Psalm working again at some point.
There's failure in main branch tests https://app.circleci.com/pipelines/github/wunderio/code-quality/257/workflows/ba91db7e-cc48-45a4-ac72-ce8cc7530c7d/jobs/300?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
This PR fixes it. After this we can create 3.0 for Code Quality and have GrumPHP 2.5 in our projects!
Screenshots
Testing
Require this branch in your project:
composer require wunderio/code-quality:dev-hotfix/99-fix-php_stan-error-with-DrupalAutoloader --dev --with-all-dependenciesDisable psalm in grumphp.yml or otherwise you'll get "The executable for "psalm" could not be found."
or