added support for secretName in PV volumeAttributes to override the default

[cameronbraid]

No description provided.

[cameronbraid]

I'd also like it to look for the secret in the same namespace as the PV/PVC

Is there any way to get this info ?

[floretan]

Looks good to me for now, although I haven't tested it. Let's do some more review when we start using this new functionality.

[Jancis]

Can't read secret from another namespace, unfortunately

Secret resources reside in a namespace . Secrets can only be referenced by Pods in that same namespace.
https://kubernetes.io/docs/concepts/configuration/secret/#details

[dvcrn]

This PR is 2 years old at this point, but I went ahead and merged it into my fork https://github.com/dvcrn/csi-rclone-reloaded

Hope upstream will reconsider it

[Jancis]

I was under impression this does not work due to technical limitation. Should probably test it.
I love the fork and examples in readme 👍
There is not much work done on this for a while as we've been using filestore and trying out nfs provisioner with hosted nfs server. It handles plugin container restarts way better.
Still, we have few ideas to change about this module in the backlog and since CSI spec seems to have changed a bit it will require at least partial rewrite anyway.

[dvcrn]

I was under impression this does not work due to technical limitation. Should probably test it.

You just made me retry this to make sure 😄
The secret needs in the same namespace as the controller, then everything is fine. So in my fork that would be kube-system

Let me add it to the README

[danielloader]

This PR is 2 years old at this point, but I went ahead and merged it into my fork https://github.com/dvcrn/csi-rclone-reloaded

Hope upstream will reconsider it

@dvcrn Just found this but your fork doesn’t include issues. Fancy merging #46 too?

[dvcrn]

Oh, Issues were not supposed to be off, I've enabled them.

I'll put it on my todo list but may take a bit until I get to it!