Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint support and configure it to use Drupal standards #318

Closed
hkirsman opened this issue Oct 28, 2022 · 1 comment
Closed

Add ESLint support and configure it to use Drupal standards #318

hkirsman opened this issue Oct 28, 2022 · 1 comment

Comments

@hkirsman
Copy link
Contributor

hkirsman commented Oct 28, 2022

I've started to work on adding javascript linter that uses rules from Drupal here wunderio/code-quality#84

I think we don't have any verification for javascript files out of the box so we should start now. Better late than never.

Drupal project is good case to test and have a discussion.

So an example let's say we have this js file:
var foo="bar"

With ESLint and Drupal rules from web/core/.eslintrc.passing.json, this would be alerted and prompted to be fixed (automatically) to this:
const foo = 'bar'

This is just one small example.

@hkirsman
Copy link
Contributor Author

I've created PR and waiting for reviews @tormi Who could I invite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant