Reading whole lines from stream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced char-by-char retrieval from stream via fread() with fgets() to get full line from stream until EOF or newline. This speeds up data transfer by factor 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced char-by-char retrieval from stream via
fread()withfgets()to get full line from stream until EOF or newline. This speeds up data transfer by factor 10.The original code reads single characters from stream until
fread()fails, returns empty char or newline. That causes a really huge loop for retrieving emails having bigger attachments. This is not different from usingfgets()which might fail or return empty string. But if there is any data, it should be trailed by a newline character. My change behaves in the same way the original code does.Querying a simple IMAP mailbox that contains 3 emails with attachments (1x 10MB, 2x 5MB attachments), the original code runs for more than 30 seconds to retrieve the emails. Applying the change, the script finishes after 3 seconds.