Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickfix #10

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Quickfix #10

merged 1 commit into from
Apr 3, 2020

Conversation

Saiv46
Copy link
Contributor

@Saiv46 Saiv46 commented Mar 29, 2020

No description provided.

wvffle
wvffle requested changes Mar 29, 2020
View reviewed changes
Copy link
Owner

@wvffle wvffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you join it by path.join? I'm unsure if those paths would work in windows.
Also can you do it for the static files?

@wvffle wvffle mentioned this pull request Mar 31, 2020
Open
@Saiv46
Copy link
Contributor Author

Saiv46 commented Apr 1, 2020

I tested on Windows, everything works as expected.

@wvffle
Copy link
Owner

wvffle commented Apr 2, 2020

Can I close #3 then?

@wvffle wvffle closed this Apr 2, 2020
@Saiv46
Copy link
Contributor Author

Saiv46 commented Apr 2, 2020 •
edited
Loading

I mean this fix works on Windows

@wvffle wvffle reopened this Apr 3, 2020
@wvffle wvffle merged commit 72f49cc into wvffle:master Apr 3, 2020
@wvffle
Copy link
Owner

wvffle commented Apr 3, 2020

Closed without merging by mistake

@Saiv46 Saiv46 deleted the patch-1 branch April 3, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvffle wvffle wvffle requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saiv46 @wvffle