Added functionality for having multiple packets open at the same time. #13
Conversation
src/App.vue
Outdated
| @@ -381,7 +380,7 @@ | |||
| } | |||
| }, | |||
| listening: false, | |||
| id_open: null, | |||
| open_ids: [], | |||
There was a problem hiding this comment.
Use a new Set() rather than an array
| } | ||
|
|
||
| window.packet = packet |
There was a problem hiding this comment.
That was for quick debugging in console. I'd rather not resign from this behavior. Having an ability to manipulate over opened packet (packets in case of this PR) in console is a must have in my case.
There was a problem hiding this comment.
Ah, so that's what it was for. I have no problem with it so I will put it back. How can you use this?
|
Let me know what those bugs are and I will see what I can do about them! I have also been working on making it work for online-mode servers. Did this also included the scope of your project? |
I've highlighted them in the review
Yup, right now localhost 1.12.2 is hardcoded as far as I remember. You should be able to change the server in the client settings |
There is now an option for toggling or you want to open multiple packets at the same time. Rename `open_ids` to `open_packets`. Also have tried to make a `Set` of it, but it didnt open them when you clicked on them.
|
idk if it's still there but you can trace |
It doesnt work anymore when its a |
|
Lets stick with an array then. Can you expose open_packets to window and I'll merge it? Edit: I've seen that you exported packet. That's ok for now |
like this? or should |
Hey,
I was looking for something like this, but I thought having multiple packets open at the same time works a bit better when you want to compare packets with each other.
And my IDE found it a good idea if some dependencies got added/were updated. 😅