Added coroutines version of roxie #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added coroutines version
Added coroutines version
Open
|
Thank you for this contribution, will need to spend some time reviewing it. Hopefully, I will have some time later this week to start to look at the changes. I was on PTO last week when this was submitted. |
|
Just to update those following this PR - @dragossusi has joined the WW team so we'll be collaborating/discussing this internally. |
|
We should migrate from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code to create rxjava2 version and coroutines version
Both can be used in the same project(check sample)
I didn't check unit tests, but the sample works.
May need maven-publish configuration for publishing the new artifacts.