Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AndroidX #4

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Migrate to AndroidX #4

merged 2 commits into from
Jan 17, 2019

Conversation

jshvarts
Copy link
Contributor

  1. Migrate to AndroidX
  2. Extract dependency versions common between sample and library into ext

@hyunwoopark hyunwoopark self-requested a review January 17, 2019 18:11
build.gradle Outdated
@@ -43,12 +43,14 @@ ext {
targetSdkVersion = 28
minSdkVersion = 14
compileSdkVersion = targetSdkVersion
supportLibVersion = '28.0.0'
appCompatVersion = '1.1.0-alpha01'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be preferable to use stable release rather than alpha.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Switched to using latest stable releases where applicable.

@jshvarts jshvarts merged commit 2026516 into master Jan 17, 2019
@jshvarts jshvarts deleted the migrate-to-androidx branch January 17, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants