-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication protocol optimization #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following top-level components that abstract the core functionality of the communication protocol and are dependent on the rest of the react components architecture
UriHandler: A Higher Order Component which is used for handling all the incoming URI requests
OpenID4VPContext: Isolated context to show the credential selection popup. Exposes an API for the OpenID4VCI protocol
OpenID4VCIContext: Exposes an API for the OpenID4VCI protocol
CredentialParsersContext: Exports credentialParserRegistry dependency which caches all metadata in memory
The following diagram describes the dependency/hierarchy between the different react contexts and Higher Order Components(HOC) in the top level of the React application. The hierarchy of the contexts was selected according to the dependencies of each corresponding hook.