Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #154

wants to merge 1 commit into from

Conversation

Yaacoub
Copy link
Contributor

@Yaacoub Yaacoub commented Jun 2, 2021

No description provided.

Copy link
Collaborator

@thisIsTheFoxe thisIsTheFoxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your PR! :)
We currently don't require a unified spelling of youtube or github.
Also, thanks for noticing other slip-ups. I'm guessing there will be a general fix after we're done with most seasonal PRs.
I'd say for now, if you want to add your Video link that's fine. But making more changes in other rows will likely cause unnecessary merge conflicts.

@thisIsTheFoxe thisIsTheFoxe requested a review from zmknox June 2, 2021 07:53
Copy link
Member

@zmknox zmknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @thisIsTheFoxe.
I think this is a worthwhile change, but it's also a big time for PRs right now. May merge after things calm down.

@Yaacoub
Copy link
Contributor Author

Yaacoub commented Jun 2, 2021

The perfectionism hidden deep in me was eager to come out. Nonetheless, I totally understand the impact these changes can have, especially in these times.

I'll make a new pull request to add only the YouTube link for my submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants