Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strobealign aemb #225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Strobealign aemb #225

wants to merge 3 commits into from

Conversation

wwood
Copy link
Owner

@wwood wwood commented Sep 28, 2024

Thoughts @AroneyS ? Tests pass on my machine, something is wrong with the CI atm. It basically just runs strobealign --aemb, but can output dense or sparse, takes multiple refs and readsets etc, so a little more ergonomic.

Still needs to make a cached strobealign index if there are multiple readsets for a single reference. Also seems like it wouldn't be hard to adjust to genome mode too, just by taking a length-weighted average of the means it predicts.

Unfortunately it can't be used as a drop-in replacement for binning, because it only reports mean, not variance.

Once this is through, can copy the template so we can use fairy as well (apparently using it as an API isn't well supported).

ben

@AroneyS
Copy link
Collaborator

AroneyS commented Oct 2, 2024

CI issue might be due to mambaforge sunsetting or mamba 2.0 (conda-incubator/setup-miniconda#366). Bin Chicken's CI broke too, was fixed by removing mamba from the test workflow yml.

Also, cargo test errors locally for me:

  --- stderr
  thread 'main' panicked at /home/aroneys/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bindgen-0.69.4/lib.rs:622:31:
  Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.so', 'libclang-*.so', 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@wwood
Copy link
Owner Author

wwood commented Oct 2, 2024

@AroneyS CI fixed - thanks for the tip. That looks like a strange linking error when you are running cargo test locally. Does the code make sense though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants