Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP Keyboard shortcuts + text search #82

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

laurgao
Copy link
Collaborator

@laurgao laurgao commented Jul 29, 2023

ctrl+k to open up quick switcher / search panel from anywhere.

todo for non mvp:

  • figure out indexes (search is slowww)
  • how to search specifying specific authors and dates
  • bugs: sometimes it highlights the whole body text, title bold highlighting works incorrectly

@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
updately ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 0:42am

@laurgao laurgao changed the base branch from main to 0.9.0 July 29, 2023 13:55
@laurgao laurgao changed the title Keyboard shortcuts [WIP] Keyboard shortcuts Jul 29, 2023
@laurgao laurgao changed the title [WIP] Keyboard shortcuts MVP Keyboard shortcuts + text search Aug 1, 2023
@wwsalmon wwsalmon mentioned this pull request Aug 5, 2023
@DronHazra
Copy link
Collaborator

DronHazra commented Aug 6, 2023

to make dealing with privacy easier, for the mvp why don't we just do searching your own updates? instead of searching all of updately? most of my use cases for searching updates involve searching my own.

@DronHazra
Copy link
Collaborator

DronHazra commented Aug 6, 2023

also, for speed, instead of using a regex we can use mongodb's actual text search feature
it would also help w/ search accuracy because it tokenizes text (i think this fixes the issue where had matches shadowed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants