-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460
Merged
swt2c
merged 1 commit into
wxWidgets:master
from
tmszi:fix-wx-agw-auimanager-bind-close-evt
Dec 18, 2023
Merged
wx.agw.aui: don't uninitialize the AuiManager if the window close event is vetoed #2460
swt2c
merged 1 commit into
wxWidgets:master
from
tmszi:fix-wx-agw-auimanager-bind-close-evt
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Sep 22, 2023
Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460
tmszi
added a commit
to OSGeo/grass
that referenced
this pull request
Sep 26, 2023
…3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Sep 26, 2023
…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list
tmszi
added a commit
to tmszi/grass
that referenced
this pull request
Sep 26, 2023
…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list
landam
pushed a commit
to landam/grass
that referenced
this pull request
Oct 25, 2023
…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list
tatarize
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked this and the problem being fixed is entirely valid.
HuidaeCho
pushed a commit
to HuidaeCho/grass
that referenced
this pull request
Jan 9, 2024
…SGeo#3177) * wxGUI/main_window: add and use custom SingleWindowAuiManager class Which override base OnClose window close event handler method to prevent prematurely uninitialize manager. wxWidgets/Phoenix#2460 * Update the package documentation class list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313.
Ssucessfully tested with wxPython demo example wxPython-demo-4.2.1/demo/agw/AUI.py file with modified
AuiFrame()
classOnClose()
close event method handler.