Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix siplib build on Windows #2610

Conversation

DietmarSchwertberger
Copy link
Contributor

When trying to build 4.2.2 with Python 3.12 on Windows 64 bit, I got an error when siplib was linked.
The symbol sipSetBool was missing.

The generated sip\siplib\setup.py has these lines, but the file content is not used when building with waf:

if sys.platform == 'win32':
    module_src.append('bool.cpp')

This PR adds bool.cpp also to wscript.

@swt2c
Copy link
Collaborator

swt2c commented Sep 15, 2024

bool.cpp was removed in sip 6.8.5. Is there some reason you can't use sip 6.8.5?

@DietmarSchwertberger
Copy link
Contributor Author

Thanks. This was not intentional. I thought build.py would check for correct prerequisites?

@swt2c
Copy link
Collaborator

swt2c commented Sep 16, 2024

Thanks. This was not intentional. I thought build.py would check for correct prerequisites?

It does for some things that it depends on (like doxygen and waf) but not for python dependencies, unfortunately as those kind of need to be installed outside of its purview. We could probably do something like that if we add a pyproject.toml, but that would mostly work for the but I'm not sure about using build.py directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants