Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link click handler #240

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Link click handler #240

merged 6 commits into from
Apr 20, 2023

Conversation

kosbog
Copy link
Contributor

@kosbog kosbog commented Apr 19, 2022

Issue #187

@kosbog
Copy link
Contributor Author

kosbog commented Apr 28, 2022

@stulip check PR, please.

@jakehasler
Copy link
Contributor

@kosbog I was also just looking for this functionality. I've got my own fork in my project now with a few small things. I'm going to try merging this into mine and seeing how it works 👍

@kosbog
Copy link
Contributor Author

kosbog commented Apr 29, 2022

@jakehasler super. Just let me know!

@jakehasler
Copy link
Contributor

@kosbog I did find a bug - that when the editor is set to disabled, it was executing the function but couldn't find the Linking variable in the scope. I haven't had a chance to look into it yet, but just an FYI.

image
image

@kosbog
Copy link
Contributor Author

kosbog commented May 2, 2022

@jakehasler ah, my stupid mistake...
Fixed.

@jakehasler
Copy link
Contributor

@kosbog I tested it out and it turned out that it was redirecting to the link right in the Webview itself, replacing the current editor content. So I adjusted my branch to have the following code:
image
Commit 1: jakehasler@97a0643
Commit 2: jakehasler@6f0580a

Also, I changed to onShouldStartLoadWithRequest to improve android compatibility based on this answer:
react-native-webview/react-native-webview#1625 (comment)

@kosbog
Copy link
Contributor Author

kosbog commented May 5, 2022

@jakehasler super! Write when you merge it, please.

@stulip
Copy link
Member

stulip commented Apr 3, 2023

Thank you, the code is conflict, please make a correction before submitting it

@kosbog
Copy link
Contributor Author

kosbog commented Apr 19, 2023

Update a branch.

@stulip stulip changed the base branch from master to v1-stable April 20, 2023 11:10
@stulip stulip merged commit 400b30b into wxik:v1-stable Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants