Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint config being generated when ESLint is not installed #1082

Open
5 tasks done
aklinker1 opened this issue Oct 19, 2024 · 1 comment
Open
5 tasks done

ESLint config being generated when ESLint is not installed #1082

aklinker1 opened this issue Oct 19, 2024 · 1 comment
Labels
bug Something isn't working contribution welcome good first issue Want to contribute to WXT? This is a good place to start

Comments

@aklinker1
Copy link
Collaborator

Describe the bug

When running wxt prepare, ESLint config is generated even when eslint isn't installed.

Reproduction

https://github.com/aklinker1/github-better-line-counts/tree/2660c4f1f7c47a1e2ace8d410e76931082507986

Steps to reproduce

bun i

And .wxt/eslintrc-auto-import.json will be created.

System Info

System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 4.91 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.20.3 - ~/.asdf/installs/nodejs/18.20.3/bin/node
    npm: 10.7.0 - ~/.asdf/plugins/nodejs/shims/npm
    bun: 1.1.31 - ~/.bunv/bin/bun
  Browsers:
    Chrome: 129.0.6668.101
    Safari: 17.2.1
  npmPackages:
    wxt: ^0.19.11 => 0.19.11

Used Package Manager

bun

Validations

@aklinker1 aklinker1 added pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug bug Something isn't working contribution welcome good first issue Want to contribute to WXT? This is a good place to start and removed pending-triage Someone (usually a maintainer) needs to look into this to see if it's a bug labels Oct 19, 2024
@aklinker1
Copy link
Collaborator Author

This probably just needs to be changed to undefined instead of defaulting to 8. Should probably return undefined from getEslintVersion in this case as well, instead of an empty tuple.

// NaN
else eslintEnabled = 8;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working contribution welcome good first issue Want to contribute to WXT? This is a good place to start
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant