-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove webextension-polyfill
#1084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklinker1
changed the title
feat!: Use extensionApi: chrome by default
feat!: Use Oct 19, 2024
extensionApi: chrome
by default
aklinker1
changed the title
feat!: Use
feat!: Remove Oct 19, 2024
extensionApi: chrome
by defaultwebextension-polyfill
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.20.0-breaking-changes #1084 +/- ##
===========================================================
- Coverage 82.07% 81.66% -0.42%
===========================================================
Files 127 125 -2
Lines 6661 6625 -36
Branches 1112 1107 -5
===========================================================
- Hits 5467 5410 -57
- Misses 1180 1198 +18
- Partials 14 17 +3 ☔ View full report in Codecov by Sentry. |
aklinker1
added a commit
that referenced
this pull request
Oct 19, 2024
aklinker1
added a commit
that referenced
this pull request
Oct 19, 2024
aklinker1
added a commit
that referenced
this pull request
Oct 19, 2024
aklinker1
added a commit
that referenced
this pull request
Dec 25, 2024
aklinker1
added a commit
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not being merged into
main
, but thev0.20.0
staging branch.BREAKING CHANGE: WXT no longer uses the
webextension-polyfill
because it doesn't provide any value anymore. As long as you're not developing a legacy MV2 extension for Chrome, nothing changes about how you're importing and using WXT'sbrowser
at runtime - your extension should behave the exact same way!However, there are a few changes you might need to make to your non-runtime code:
browser
variable, not separate imports:extensionApi
option in yourwxt.config.ts
, remove it:export default defineConfig({ - extnsionApi: "chrome", });
wxt/browser/chrome
, you can go back to importing fromwxt/browser
:To continue using the polyfill, install the NPM package and import it instead of using
wxt/browser
: