-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hooks): Move entrypoints:resolved
before debug logs and add entrypoints:found
#1292
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
probably should change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is perfect!
Thoughts on renaming entrypoints:paths
to entrypoints:found
or entrypoints:discovered
? This would better align with the noun:past-tense-verb
naming convention we use for most of the other hooks. I realized entrypoints:paths
wasn't a very good name after sleeping on it lol.
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-solid
@wxt-dev/module-react
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
wxt
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
+ Coverage 81.11% 81.18% +0.06%
==========================================
Files 128 128
Lines 6280 6281 +1
Branches 1065 1064 -1
==========================================
+ Hits 5094 5099 +5
+ Misses 1171 1167 -4
Partials 15 15 ☔ View full report in Codecov by Sentry. |
any changes required to the addition in the docs? |
Maybe a recipe on the modules page for adding an entrypoint using the new hook. |
Alright, thanks for adding this! The new hook will be very useful. Great quality PR too 👍 |
Hmm, not sure why those checks are failing... I'll get it sorted out and get the PR merged soon. Holidays and family in town starting tomorrow, so it might be a few days before I can look into this. |
Looks like it's related to vite 6.0.4: #1293 |
entrypoints:resolved
hook and init entrypoints:paths
hookentrypoints:resolved
hook and init entrypoints:found
hook
entrypoints:resolved
hook and init entrypoints:found
hookentrypoints:resolved
hook and add entrypoints:found
hook
entrypoints:resolved
hook and add entrypoints:found
hookentrypoints:resolved
before debug logs and add entrypoints:found
as mentioned in #1072, there's a requirement for a hook to manipulate entrypoint resolution before loading them.
findEntrypoints()
function since the issue, it's a bit outdated and the solution right now is to just move theentrypoints:resolved
hook to before logging.entrypoints:paths
hook to be able to manipulate theentrypointInfo
variable.