Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable opening browser automatically during dev mode #136

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Sep 30, 2023

This closes #135. New runner.disable field in config.

// wxt.config.ts
export default defineConfig({
  runner: {
    disabled: true,
  },
});

OR

// web-ext.config.ts - should be gitignored
defineRunnerConfig({
  disabled: true
});

@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit cef89b2
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/651823e08aab58000778dc0e
😎 Deploy Preview https://deploy-preview-136--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #136 (cef89b2) into main (e97071b) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 59.09%.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   84.52%   84.48%   -0.05%     
==========================================
  Files          50       52       +2     
  Lines        3930     3971      +41     
  Branches      357      361       +4     
==========================================
+ Hits         3322     3355      +33     
- Misses        608      616       +8     
Files Coverage Δ
src/core/runners/index.ts 100.00% <100.00%> (+62.50%) ⬆️
src/core/types/external.ts 100.00% <100.00%> (ø)
src/core/utils/getInternalConfig.ts 98.02% <100.00%> (+<0.01%) ⬆️
src/core/utils/wsl.ts 42.85% <42.85%> (ø)
src/core/runners/manual.ts 33.33% <33.33%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aklinker1 aklinker1 marked this pull request as ready for review September 30, 2023 13:45
@aklinker1 aklinker1 merged commit 89d15ba into main Sep 30, 2023
6 of 8 checks passed
@aklinker1 aklinker1 deleted the disable-runner branch September 30, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to add a field to disable AutoLaunch?
1 participant