-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Remove lib
from .wxt/tsconfig.json
#209
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the PR! It makes more sense to remove the I added it because If people want web worker types, they can add them to their own tsconfig. I can add docs around TSConfig customization. |
OK. I have updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I updated the test snapshots that were failing, and reverted the whitespace change for now, I'll do it separately, it was causing a large diff with the test snapshot for some reason, I'll update it separately.
lib
from .wxt/tsconfig.json
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 63.81% 63.82% +0.01%
==========================================
Files 74 74
Lines 5784 5783 -1
Branches 460 459 -1
==========================================
Hits 3691 3691
+ Misses 2057 2056 -1
Partials 36 36
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
lib
is mismatched cause we manual setlib
option so that override the default value which effected bytarget
option.