Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate valid manifest for Firefox MV3 #229

Merged
merged 3 commits into from
Nov 11, 2023
Merged

fix: Generate valid manifest for Firefox MV3 #229

merged 3 commits into from
Nov 11, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Nov 11, 2023

This closes #226

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit ad7c465
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/654fc4e14402720008c23445
😎 Deploy Preview https://deploy-preview-229--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 mentioned this pull request Nov 11, 2023
@aklinker1 aklinker1 self-assigned this Nov 11, 2023
@aklinker1 aklinker1 added the bug Something isn't working label Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #229 (ad7c465) into main (67ffa44) will decrease coverage by 0.07%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   63.85%   63.78%   -0.07%     
==========================================
  Files          74       74              
  Lines        5812     5823      +11     
  Branches      463      466       +3     
==========================================
+ Hits         3711     3714       +3     
- Misses       2064     2072       +8     
  Partials       37       37              
Files Coverage Δ
src/core/utils/manifest.ts 33.27% <16.66%> (+0.25%) ⬆️
src/core/runners/web-ext.ts 14.66% <0.00%> (-1.28%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aklinker1 aklinker1 mentioned this pull request Nov 11, 2023
3 tasks
@aklinker1 aklinker1 marked this pull request as ready for review November 11, 2023 18:18
@aklinker1 aklinker1 merged commit 281f281 into main Nov 11, 2023
@aklinker1 aklinker1 deleted the firefox-mv3 branch November 11, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Firefox MV3
1 participant