Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use bun to load entrypoint config #232

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Nov 11, 2023

Apart of #222. Fixes one issue with getting WXT working inside bun.

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 29ac060
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/654fe6d868bb9d00088e9b06
😎 Deploy Preview https://deploy-preview-232--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 self-assigned this Nov 11, 2023
@aklinker1 aklinker1 marked this pull request as ready for review November 11, 2023 20:41
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #232 (29ac060) into main (91b28c2) will decrease coverage by 0.11%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   64.08%   63.98%   -0.11%     
==========================================
  Files          75       75              
  Lines        5895     5898       +3     
  Branches      474      473       -1     
==========================================
- Hits         3778     3774       -4     
- Misses       2080     2087       +7     
  Partials       37       37              
Files Coverage Δ
src/core/utils/building/import-entrypoint.ts 50.56% <100.00%> (-6.42%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aklinker1 aklinker1 mentioned this pull request Nov 11, 2023
3 tasks
@aklinker1 aklinker1 merged commit 44d715a into main Nov 11, 2023
16 checks passed
@aklinker1 aklinker1 deleted the bun-entrypoint-fix branch November 11, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant