Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow plural directory and only png's for manifest icons #237

Merged
merged 4 commits into from
Nov 15, 2023
Merged

feat!: Allow plural directory and only png's for manifest icons #237

merged 4 commits into from
Nov 15, 2023

Conversation

dvlden
Copy link
Contributor

@dvlden dvlden commented Nov 14, 2023

This PR resolves #235

  • allow only png's
  • improve regex to allow plural directory name

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 61e8a03
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6553d64394033f0008e8868c
😎 Deploy Preview https://deploy-preview-237--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (207b750) 63.94% compared to head (61e8a03) 63.96%.

Files Patch % Lines
src/core/utils/manifest.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   63.94%   63.96%   +0.01%     
==========================================
  Files          75       75              
  Lines        5902     5902              
  Branches      473      474       +1     
==========================================
+ Hits         3774     3775       +1     
+ Misses       2091     2090       -1     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 changed the title feat: allow plural directory and only png's for manifest icons feat!: Allow plural directory and only png's for manifest icons Nov 15, 2023
@aklinker1 aklinker1 merged commit 046a480 into wxt-dev:main Nov 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve regex for manifest icons
2 participants