Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auto-imports): Don't add imports to node_module dependencies #247

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Nov 28, 2023

Node modules are already bundled and ready to go, imports should never be added. It seems like this could be caused by several issues with unimport, but those only really happen inside node_modules.

This closes #246

@aklinker1 aklinker1 added the bug Something isn't working label Nov 28, 2023
@aklinker1 aklinker1 self-assigned this Nov 28, 2023
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 4e2c09e
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/65662cced7fd910008ec1367
😎 Deploy Preview https://deploy-preview-247--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (762ba00) 64.30% compared to head (4e2c09e) 64.28%.

Files Patch % Lines
src/core/vite-plugins/unimport.ts 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   64.30%   64.28%   -0.03%     
==========================================
  Files          76       76              
  Lines        6024     6029       +5     
  Branches      487      488       +1     
==========================================
+ Hits         3874     3876       +2     
- Misses       2113     2116       +3     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit df13b97 into main Nov 28, 2023
16 checks passed
@aklinker1 aklinker1 deleted the disable-unimport-for-dependencies branch November 28, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build Vue + Headless UI
1 participant