Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve content script UI guide #272

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Dec 12, 2023

Apply suggestions from #267

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 63818f6
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6578964f7218ca0008accb80
😎 Deploy Preview https://deploy-preview-272--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -86,7 +86,7 @@ export interface ContentScriptModalPositioningOptions {
/**
* Choose between `"inline"`, `"overlay"`, or `"modal" `types.
*
* ![Visualization of different types](https://wxt.dev/content-script-ui-types.png)
* ![Visualization of different types](https://wxt.dev/content-script-ui-type.png)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo in filename

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcb93af) 69.97% compared to head (63818f6) 69.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   69.97%   69.97%           
=======================================
  Files         133      133           
  Lines        7365     7365           
  Branches      571      572    +1     
=======================================
  Hits         5154     5154           
  Misses       2161     2161           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review December 12, 2023 17:33
@aklinker1 aklinker1 self-assigned this Dec 12, 2023
@aklinker1 aklinker1 added the docs Improvements or additions to documentation label Dec 12, 2023
@aklinker1 aklinker1 merged commit 6f902cc into main Dec 13, 2023
16 checks passed
@aklinker1 aklinker1 deleted the improve-content-script-ui-docs branch December 13, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant