Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only use type imports for Vite #278

Merged
merged 3 commits into from
Dec 12, 2023
Merged

fix: Only use type imports for Vite #278

merged 3 commits into from
Dec 12, 2023

Conversation

aklinker1
Copy link
Collaborator

This closes #277.

@aklinker1 aklinker1 self-assigned this Dec 12, 2023
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit f465ebb
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6578be49659ed00007d5aaa1
😎 Deploy Preview https://deploy-preview-278--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 added the bug Something isn't working label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1cf866) 70.15% compared to head (f465ebb) 70.15%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   70.15%   70.15%           
=======================================
  Files         133      133           
  Lines        7377     7377           
  Branches      573      573           
=======================================
  Hits         5175     5175           
  Misses       2152     2152           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review December 12, 2023 20:10
@aklinker1 aklinker1 merged commit 7c02497 into main Dec 12, 2023
16 checks passed
@aklinker1 aklinker1 deleted the vite-5-warning branch December 12, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Vite 5 CJS warning
1 participant