Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable Vite CJS warnings #296

Merged
merged 5 commits into from
Dec 23, 2023
Merged

fix: Disable Vite CJS warnings #296

merged 5 commits into from
Dec 23, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Dec 23, 2023

Apart of #277, this just hides the warning. It's still a problem, but the problem is in c12 and jiti, so right now the plan is to wait for them to be fixed.

Check out any of the template jobs from the validate workflow. The npm run build and npm i *.tgz steps should not show the warning anymore.

The original npm i will contain the log because it installs the current production version, which doesn't have this fix.


Before: https://github.com/wxt-dev/wxt/actions/runs/7306147108/job/19910552197

Screenshot 2023-12-23 at 9 17 08 AM

After: https://github.com/wxt-dev/wxt/actions/runs/7309075494/job/19916319577

Screenshot 2023-12-23 at 9 33 43 AM

Copy link

netlify bot commented Dec 23, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit e352c2d
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6586fd75ba4cb800085e7faf
😎 Deploy Preview https://deploy-preview-296--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ad0e8e4) 70.43% compared to head (e352c2d) 70.40%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/cli.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   70.43%   70.40%   -0.03%     
==========================================
  Files         134      134              
  Lines        7509     7512       +3     
  Branches      584      584              
==========================================
  Hits         5289     5289              
- Misses       2168     2171       +3     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 self-assigned this Dec 23, 2023
@aklinker1 aklinker1 added the bug Something isn't working label Dec 23, 2023
@aklinker1 aklinker1 marked this pull request as ready for review December 23, 2023 15:34
@aklinker1 aklinker1 merged commit b4a2cf4 into main Dec 23, 2023
16 checks passed
@aklinker1 aklinker1 deleted the hide-vite-cjs-warning branch December 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant