Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: New wxt/storage APIs #300

Merged
merged 6 commits into from
Dec 27, 2023
Merged

feat!: New wxt/storage APIs #300

merged 6 commits into from
Dec 27, 2023

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Dec 26, 2023

This closes #228. This will be the storage util provided in v1.0, unless people have really strong feelings about it not being good enough.

  • Implement
  • Test
  • Try in demo extension
  • Add docs

@aklinker1 aklinker1 self-assigned this Dec 26, 2023
Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 48adcb0
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/658c56f084d987000869c1d6
😎 Deploy Preview https://deploy-preview-300--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e1f1813) 70.40% compared to head (48adcb0) 72.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/storage.ts 98.07% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   70.40%   72.54%   +2.14%     
==========================================
  Files         134      134              
  Lines        7511     7980     +469     
  Branches      583      669      +86     
==========================================
+ Hits         5288     5789     +501     
+ Misses       2171     2139      -32     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review December 27, 2023 16:55
@aklinker1 aklinker1 merged commit d1b9e5d into main Dec 27, 2023
16 checks passed
@aklinker1 aklinker1 deleted the storage-update branch December 27, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Storage API (looking for feedback)
1 participant