Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Support multiple : characters in storage keys #303

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

aklinker1
Copy link
Collaborator

This closes #302

Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 55d3880
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/658e69667e22fb00081fc69e
😎 Deploy Preview https://deploy-preview-303--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title fix(storage): Support multiple : characters in keys fix(storage): Support multiple : characters in storage keys Dec 29, 2023
@aklinker1 aklinker1 marked this pull request as ready for review December 29, 2023 06:39
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ad099b) 72.54% compared to head (55d3880) 72.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   72.54%   72.55%           
=======================================
  Files         134      134           
  Lines        7980     7982    +2     
  Branches      669      670    +1     
=======================================
+ Hits         5789     5791    +2     
  Misses       2139     2139           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit e6657cb into main Dec 29, 2023
16 checks passed
@aklinker1 aklinker1 deleted the storage-split-fix branch December 29, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage saved to wrong location when multiple : are present in key
1 participant