Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Module system #672

Merged
merged 23 commits into from
Jun 11, 2024
Merged

feat: Module system #672

merged 23 commits into from
Jun 11, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented May 24, 2024

This closes #665.

See new docs to get started with modules: https://deploy-preview-672--creative-fairy-df92c4.netlify.app/guide/go-further/reusable-modules.html or if this is already merged, https://wxt.dev/guide/go-further/reusable-modules.html

Todo

  • defineWxtModule
    • Resolve options from wxt.config.ts
    • Verify option types can be appended to InlineConfig interface so devs get type hints inside wxt.config.ts
  • addPublicAssets
  • addViteConfig
  • addEntrypoint
  • addWxtPlugin
  • Custom imports
  • Add docs

@aklinker1 aklinker1 changed the title feat: Module system feat: Experimental module system May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 49b20e9
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6668d1e06d8a9e00086b06f9
😎 Deploy Preview https://deploy-preview-672--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 force-pushed the main branch 2 times, most recently from 3198234 to c39087a Compare May 31, 2024 06:28
@aklinker1 aklinker1 force-pushed the plugin-system branch 2 times, most recently from 30e7895 to 68e1eaf Compare June 9, 2024 15:02
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 87.69231% with 48 lines in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (34ea230) to head (49b20e9).

Files Patch % Lines
packages/wxt/src/modules.ts 81.53% 24 Missing ⚠️
...ages/wxt/src/core/utils/building/resolve-config.ts 88.52% 7 Missing ⚠️
packages/wxt/src/sandbox/define-wxt-plugin.ts 0.00% 4 Missing and 1 partial ⚠️
.../src/core/builders/vite/plugins/wxtPluginLoader.ts 95.16% 3 Missing ⚠️
packages/wxt/src/virtual/background-entrypoint.ts 0.00% 2 Missing ⚠️
...irtual/content-script-isolated-world-entrypoint.ts 0.00% 2 Missing ⚠️
...rc/virtual/content-script-main-world-entrypoint.ts 0.00% 2 Missing ⚠️
...ages/wxt/src/virtual/unlisted-script-entrypoint.ts 0.00% 2 Missing ⚠️
packages/wxt/src/sandbox/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   86.80%   87.35%   +0.55%     
==========================================
  Files         114      117       +3     
  Lines        9241     9620     +379     
  Branches      930      962      +32     
==========================================
+ Hits         8022     8404     +382     
+ Misses       1205     1201       -4     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1
Copy link
Collaborator Author

@Timeraa This work is done! I'll provide some examples to help you get started with the devtools soon...

@aklinker1 aklinker1 marked this pull request as ready for review June 11, 2024 22:06
@aklinker1 aklinker1 changed the title feat: Experimental module system feat: Module system Jun 11, 2024
@aklinker1 aklinker1 merged commit b3ddab7 into main Jun 11, 2024
15 checks passed
@aklinker1 aklinker1 deleted the plugin-system branch June 11, 2024 22:45
@Timeraa
Copy link
Contributor

Timeraa commented Jun 12, 2024

@Timeraa This work is done! I'll provide some examples to help you get started with the devtools soon...

Sounds good!

@aklinker1 aklinker1 mentioned this pull request Aug 16, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modules - API Proposal
2 participants