Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Externalize app config during dependency optimization #833

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Jul 21, 2024

This closes #830

Copy link

netlify bot commented Jul 21, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit f5a6c48
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/669d0da964714200081a8c02
😎 Deploy Preview https://deploy-preview-833--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 marked this pull request as ready for review July 21, 2024 13:31
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (7ee391f) to head (f5a6c48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   87.02%   86.97%   -0.05%     
==========================================
  Files         120      120              
  Lines       10120    10129       +9     
  Branches     1001      995       -6     
==========================================
+ Hits         8807     8810       +3     
- Misses       1298     1304       +6     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 069bd6c into main Jul 21, 2024
16 checks passed
@aklinker1 aklinker1 deleted the fix-app-config-resolution branch July 21, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[app.config.ts] Could not resolve "virtual:app-config"
1 participant