Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(size)!: Switch from tsup to unbuild for building WXT #848

Merged
merged 12 commits into from
Jul 24, 2024
Merged

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Jul 23, 2024

BREAKING CHANGE: Drop CJS support


I was having some weird behavior with dev mode module resolution in #847, and wanted to simplify the build output to see if that would have any effect. Haven't tested it yet, but as you can see below, it's a good change anyways:

TSUP Unbuild
Packed size 431 kB 114 kB
Unpacked size 1.89 mb 656 kB
Build time 6.419 s 3.002 s

Other changes:

  • Removed ~ typscript path, doesn't work with mkdist
  • Dropped support for CJS

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 2229798
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/66a1057687d2870008346ffc
😎 Deploy Preview https://deploy-preview-848--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 changed the title chore: Switch from tsup to mkdist for building WXT chore: Switch from tsup to unbuild for building WXT Jul 23, 2024
@aklinker1 aklinker1 changed the title chore: Switch from tsup to unbuild for building WXT perf(size): Switch from tsup to unbuild for building WXT Jul 24, 2024
@aklinker1 aklinker1 changed the title perf(size): Switch from tsup to unbuild for building WXT perf(size)!: Switch from tsup to unbuild for building WXT Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 98.97959% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.43%. Comparing base (c69e51c) to head (1154128).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/virtual/content-script-main-world-entrypoint.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
+ Coverage   82.35%   82.43%   +0.08%     
==========================================
  Files         112      112              
  Lines        6278     6280       +2     
  Branches     1018     1019       +1     
==========================================
+ Hits         5170     5177       +7     
+ Misses       1095     1090       -5     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review July 24, 2024 12:50
@aklinker1 aklinker1 merged commit 5eb5be7 into main Jul 24, 2024
14 checks passed
@aklinker1 aklinker1 deleted the unbuild branch July 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant