-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auto Icons Module #851
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@aklinker1 I noticed a small issue with the wxt module system, is there a way to get the module options in hooks? Because right now you would need to restart the whole process in order for the options to update. Also if you want me to update any documentation, do let me know where |
Are you saying if someone saves the |
Yep exactly that! It totally makes sense why but probably something to think about! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just a couple of small changes.
What are your thoughts on the module-
prefix for the package names? I wanted it to be consistent, but now I'm regretting it... @wxt-dev/auto-icons
sounds good, @wxt-dev/module-auto-icons
seems redundant 😵💫
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 82.17% 82.06% -0.12%
==========================================
Files 113 113
Lines 6323 6311 -12
Branches 1029 1029
==========================================
- Hits 5196 5179 -17
- Misses 1113 1118 +5
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Edit: I added the For the build summary issue... I think we can just add the icon files to the wxt.hooks.hook("build:done", (wxt, output) => {
output.publicAssets.push({ type: "asset", file: "icons/16.png");
}); |
I can make it just auto-icons if ya want, just did fit for consistency haha |
Oh gosh what did I do to the branch |
Implemented the requested changes @aklinker1, I also updated the background.ts so that the /icons path is correct in the geturl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented the requested changes @aklinker1, I also updated the background.ts so that the /icons path is correct in the geturl
Perfect, thanks. Everything looks good now.
I can make it just auto-icons if ya want, just did fit for consistency haha
Hmmmmmmmmmmmmmmmmmm... Yeah, let's rename it to just @wxt-dev/auto-icon
Adds a new module to wxt to automatically generate icons for the manifest
icons
field using sharpCloses #850
For the structure (package.json, tsconfig) I copied the one from the vue module, had to add a build config for fs-extra