update comment on localhost check and add test for case localhost4.lo…

…calhost42
wxtim · Mar 20, 2023 · 83484ef · 83484ef
1 parent 6a21157
commit 83484ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cylc/flow/hostuserutil.py b/cylc/flow/hostuserutil.py
@@ -198,7 +198,7 @@ def is_remote_host(self, name):
         """
         if name not in self._remote_hosts:
             if not name or name.split(".")[0].startswith("localhost"):
-                # e.g. localhost.localdomain
+                # e.g. localhost42.localdomain42
                 self._remote_hosts[name] = False
             else:
                 try:

diff --git a/tests/unit/test_hostuserutil.py b/tests/unit/test_hostuserutil.py
@@ -35,10 +35,11 @@ def test_is_remote_user_on_current_user():
     assert not is_remote_user(os.getenv('USER'))
 
 
-def test_is_remote_host_on_localhost():
+def test_is_remote_host_on_localhost(monkeypatch):
     """is_remote_host with localhost."""
     assert not is_remote_host(None)
     assert not is_remote_host('localhost')
+    assert not is_remote_host('localhost4.localhost42')
     assert not is_remote_host(os.getenv('HOSTNAME'))
     assert not is_remote_host(get_host())