[#161102] Adds active_storage_for_images_only feature flag

app/lib/settings_helper.rb

@@ -29,6 +29,10 @@ def self.relays_enabled_for_reservation?
     setting "relays.#{Rails.env}.reservation_enabled"
   end
 
+  def self.active_storage_enabled?
+    feature_on?(:active_storage) || feature_on?(:active_storage_for_images_only)
+  end
+
   #
   # Used to query the +Settings+ under feature:
   # [_feature_]

app/models/concerns/active_storage_file.rb

@@ -9,7 +9,7 @@ module ActiveStorageFile
     has_one_attached :file
 
     def assign_attributes(new_attributes)
-      if SettingsHelper.feature_on?(:active_storage)
+      if SettingsHelper.active_storage_enabled?
         # Ensure the file name and file_type are set first when attaching a StringIO
         # see #file= method below
         assign_first = new_attributes.extract!(:name, :file_type)

app/models/concerns/downloadable_files/image.rb

@@ -3,26 +3,35 @@ module DownloadableFiles
   module Image
 
     extend ActiveSupport::Concern
-    include DownloadableFile
+
+    if SettingsHelper.active_storage_enabled?
+      include ActiveStorageFile
+    else
+      include PaperclipFile
+    end
 
     included do
       attr_reader :remove_file
 
       before_validation { delete_file if remove_file }
 
-      if SettingsHelper.feature_on?(:active_storage)
+      if SettingsHelper.active_storage_enabled?
         validates :file, content_type: ["image/jpg", "image/jpeg", "image/png", "image/gif"]
       else
         validates_attachment :file, content_type: { content_type: ["image/jpg", "image/jpeg", "image/png", "image/gif"] }
       end
     end
 
+    def file_present?
+      file.present?
+    end
+
     def remove_file=(value)
       @remove_file = !value.to_i.zero?
     end
 
     def padded_image(width: 400, height: 200, background_color: "rgb(231, 231, 231)")
-      if SettingsHelper.feature_on?(:active_storage)
+      if SettingsHelper.active_storage_enabled?
         download_url.variant(resize_and_pad: [width, height, { background: background_color }])
       else
         download_url

config/settings.yml

@@ -130,7 +130,8 @@ feature:
   bypass_kiosk_auth: false
   revenue_account_editable: false
   active_storage: false
-  facility_tile_list: false
+  active_storage_for_images_only: false
+  facility_tile_list: <%= ENV.fetch("FACILITY_TILE_LIST", false) %>  
   facility_tile_list_admin: false
   po_require_affiliate_account: true
 

doc/HOWTO_feature_flags.md

@@ -56,3 +56,4 @@
 * `kiosk_view` Kiosk mode - display a list of actionable reservations without logging in (optionally allow acting w/o auth)
 * `reservations: grace_period`, `reservations: timeout_period`, `occupancies: timeout_period`, `billing: review_period` various grace periods, time periods, and review periods
 * `active_storage` use `ActiveStorage` if `true`, or `Paperclip` if `false`
+* `active_storage_for_images_only` enables `ActiveStorage` for the `DownloadableFiles::Image` module. This flag does not need to be enabled if `active_storage` is