-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error handling #4856
Draft
diebas
wants to merge
19
commits into
master
Choose a base branch
from
refactor-error-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor error handling #4856
+216
−416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diebas
force-pushed
the
refactor-error-handling
branch
3 times, most recently
from
December 20, 2024 13:53
4b0e849
to
6df5639
Compare
Also run `rails g controller errors not_found internal_server_error`
diebas
force-pushed
the
refactor-error-handling
branch
from
December 23, 2024 13:57
6df5639
to
90d4c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
A one- or two-sentence explanation of what the change is and why, phrased for a non-technical audience. This should be copy-pasted as your commit message when the PR is merged. (Required)
Please preface your release note with "TECH TASK: " if the change is a technical task such as a gem upgrade or changes to a configuration file.
Screenshot
Optional.
Additional Context
Optional. Feel free to add/modify additional headers as appropriate, e.g. "Refactorings", "Concerns".
Accessibility